On Wed, Jul 29, 2009 at 01:57:30AM -0300, Mauro Carvalho Chehab wrote: > Ah, yes, there's a missing mute/unmute issue there. Instead of using > your code, I opted to duplicate part of ac97_set_ctrl code there. > > I opted to have a small duplicated code, but, IMO, it is now clearer > to see why we still need to call em28xx_audio_analog_set(). You will > notice that I've rearranged the place where I update volume and > mute. The rationale is that v4l2_device_call_all() might eventually > change a value for volume/mute. > > Another reason is that, IMO, v4l2_device_call_all() should return values. In > the specific case of volume/mute, if the user tries to specify a > value outside the range, the -ERANGE should be returned. > > I've already committed the patches at the tree. Please double-check. > It doesn't work. Mplayer locks up. There's no video window, but sound works. The only way to kill mplayer is rebooting the machine. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
