On Saturday 25 July 2009 16:08:01 Eduardo Valentin wrote: > On Sat, Jul 25, 2009 at 04:10:53PM +0200, ext Hans Verkuil wrote: > > On Friday 24 July 2009 18:42:12 Eduardo Valentin wrote: > > > As there can be modulator devices with get/set frequency > > > callbacks, this patch adds support to them in v4l2-ctl utility. > > > > Thanks for this patch. > > > > I've implemented it somewhat differently (using the new V4L2_CAP_MODULATOR > > to decide whether to call G_TUNER or G_MODULATOR) and pushed it to my > > v4l-dvb-strctrl tree. I've also improved the string print function so things > > like newlines and carriage returns are printed as \r and \n. > > > > Can you mail me the output of 'v4l2-ctl --all -L' based on this updated > > version of v4l2-ctl? I'd like to check whether everything is now reported > > correctly. > > Yes sure. But there is also the RDS output for txsubchannel. This is missing > now for G_MODULATOR. RDS is also missing in S_MODULATOR. Added both. > S_MODULATOR is also > confusing to me. The strings can be set only with one value? I though I could > do something like: > > v4l2-ctl -d /dev/radio0 --set-modulator=rds,stereo The reason I did that is that txsubchans only supports specific flag combinations. So rather than having to make all sorts of verification code I decided to make these combinations explicit. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
