Hello Hans, I looked into the patch - just to be informed what's going on and got confused by such code. I reimplemented it to test it against side effects and still do not understand why it is written so complicated. Sure, I don't know the environment of the code, but does it matter in this case ? If you like try these few lines (the last 3 lines) as a replacement: unsigned long USALS; int CMD1; int CMD2; if ( azimuth>0.0 ) CMD1 = 0xE0; // East else CMD1 = 0xD0; // West /*-----------------------------------------------*/ USALS = ( fabs( azimuth ) * 16.0 + 0.5 ); CMD1 |= ( USALS & 0xf00 ) >> 8; CMD2 = ( USALS & 0x0ff ); /*-----------------------------------------------*/ Regards /Jesko -----Ursprüngliche Nachricht----- Von: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media-owner@xxxxxxxxxxxxxxx] Im Auftrag von Hans Werner Gesendet: Dienstag, 14. Juli 2009 01:21 An: linux-media@xxxxxxxxxxxxxxx Betreff: [BUG][PATCH] kaffeine 0.8.8 USALS/GotoX problem There is a bug in DvbStream::gotoX in Kaffeine 0.8.8, which is fixed by the attached patch. Look for example at what happens when azimuth = 15.951. The motor should be driven to 16.0 degrees, but when 15.951 is rounded up with if (USALS>0.5) ++rd; the carries into the upper nibble of CMD2 and the lower nibble of CMD1 are not handled properly. The result is CMD1 represents 0 instead of 16 degrees and CMD2 is undefined, being set by the non-existent 11th element of DecimalLookup. The patch fixes it, and I also took the opportunity to fix the strange division by while loops. Regards, Hans -- GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
