Re: Fix for crash in dvb-usb-af9015

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Antti,

Antti Palosaari wrote:
> Nils Kassube wrote:
> > As I'm not familiar with the hardware, I can't say what buffer size
> > would be appropriate but I can say that for my device the parameter
>
> I see the problem but your fix is not ideally correct for my eyes. 

You're probably right - like I wrote, I'm not familiar with the 
hardware.

> I
> don't have currently access to sniffs to ensure that but I think BOOT
> should be write command. Now it is defined as read. I think moving
> BOOT from read to write fixes problem.

Yes, that makes a lot of sense to me. Therefore I changed the code to 
make it a write command like this:

--- orig/linux-2.6.31/drivers/media/dvb/dvb-usb/af9015.c	2009-06-30 
11:34:45.000000000 +0200
+++ linux-2.6.31/drivers/media/dvb/dvb-usb/af9015.c	2009-07-07 
14:58:27.000000000 +0200
@@ -81,7 +81,6 @@
 
 	switch (req->cmd) {
 	case GET_CONFIG:
-	case BOOT:
 	case READ_MEMORY:
 	case RECONNECT_USB:
 	case GET_IR_CODE:
@@ -100,6 +99,7 @@
 	case WRITE_VIRTUAL_MEMORY:
 	case COPY_FIRMWARE:
 	case DOWNLOAD_FIRMWARE:
+	case BOOT:
 		break;
 	default:
 		err("unknown command:%d", req->cmd);

And of course I removed the earlier change. With this modification it 
works as well.


Nils

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux