On Fri, 3 Jul 2009, Antonio Ospite wrote: > On Wed, 1 Jul 2009 20:43:25 +0200 > Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote: > > > Hi, > > > > I get this with pxa-camera in mainline linux (from today). > > I haven't touched my board code which used to work in 2.6.30 > > > > I think I've tracked down the cause. The board code is triggering a > bug in pxa_camera. The same should apply to mioa701 as well. > > > Linux video capture interface: v2.00 > > Unable to handle kernel NULL pointer dereference at virtual address 00000060 > > pgd = c0004000 > > [00000060] *pgd=00000000 > > Internal error: Oops: f5 [#1] PREEMPT > > Modules linked in: > > CPU: 0 Tainted: G W (2.6.31-rc1-ezxdev #1) > > PC is at dev_driver_string+0x0/0x38 > > LR is at pxa_camera_probe+0x144/0x428 > > The offending dev_driver_str() here is the one in the dev_warn() call in > mclk_get_divisor(). > > This is what is happening: in struct pxacamera_platform_data I have: > .mclk_10khz = 5000, > > which makes the > test in mclk_get_divisor() succeed calling dev_warn > to report that the clock has been limited, but pcdev->soc_host.dev is > still uninitialized at this time. > > I could lower the value in my platform data and avoid the bug, but it > would be good to have this fixed ASAP anyway. > > The attached rough patch fixes the problem, but you will surely come > out with a better one :) Why should I? Your patch seems correct to me so far, thanks. I'll push it for 2.6.31. Please, next time inline your patch as described in Documentation/SubmittingPatches. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
