On Monday 29 June 2009, Karicheri, Muralidharan wrote:
> <snip>
> >> >
> >> > -static struct tvp514x_platform_data tvp5146_pdata = {
> >> > - .clk_polarity = 0,
> >> > - .hs_polarity = 1,
> >> > - .vs_polarity = 1
> >
> >Clearly this patch is against neither mainline nor the
> >current DaVinci GIT tree... I suggest reissuing against
> >mainline, now that it's got most DM355 stuff.
> >
>
> That is because, I have my first (vpfe capture version v3)
> patch lined up for merge to upstream/davinci git kernel ...
>
> >>NOTE: Depends on v3 version of vpfe capture driver patch
>
> What is your suggestion in such cases?
Always submit against mainline. In the handfull of cases
that won't work (e.g. depends on code that's not there),
submit against the DaVinci tree.
> >> > +static const struct i2c_device_id dm355evm_msp_ids[] = {
> >> > + { "dm355evm_msp", 0, },
> >> > + { /* end of list */ },
> >> > +};
> >
> >Needless to say: NAK on all this. There is already a
> >drivers/mfd/dm355evm_msp.c managing this device. You
> >shouldn't have video code crap all over it.
> >
> >It currently sets up for TVP5146 based capture iff that
> >driver is configured (else the external imager); and
> >exports the NTSC/nPAL switch setting as a GPIO that's
> >also visible in sysfs.
> >
> >I suggest the first revision of this VPFE stuff use
> >the existing setup. A later patch could add some
> >support for runtime reconfiguration.
> >
> I didn't know that you have a video code crap added to
> drivers/mfd/dm355evm_msp.c :)
:)
It's just setting up everything the msp430 touches,
so the board is in a known sane state. Standard
stuff for initialization code.
> The first patch is already out and is using TVP5146.
> So I will investigate your msp driver and see how I
> can support run time configuring the input.
> If you have any suggestion let me know.
>
> Wondering why you chose to make msp driver dm355
> specific? MSP430 is available on dm6446 and dm355, right?
The MSP430 is a microcontroller family. The firmware used
on each board is extremely board-specific. On DM355 EVM,
the firmware's I2C interface was at least sanely structured.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
