> >). I started by converting mx3-camera and mt9t031, and I shall upload an >incomplete patch, converting only these drivers to my "testing" area, >while I shall start converting the rest of the drivers... So, it is >advisable to wait for that patch to appear and base any future (including >this one) work on it, because it is a pretty big change and merging would >be non-trivial. > I thought you wanted to offload some of the migration work and I had volunteered to do this since it is of interest to vpfe-capture. I don't see a point in duplicating the work already done by me. So could you please work with me by reviewing this patch and then use this for your work? I will take care of merging any updates to this based on your patches (like the crop one) > >> > >> { >> > >> - s32 data = i2c_smbus_read_word_data(client, reg); >> > >> + s32 data; >> > >> + >> > >> + data = i2c_smbus_read_word_data(client, reg); >> > >> return data < 0 ? data : swab16(data); > >Looks like it will take me considerable time to review the patch and NAK >all changes like this one... > I didn't get it. Are you referring to the 3 lines of code above? For this patch this code change is unnecessary, but I have to do this if sd is used as argument to this function as suggested by Hans. >Thanks >Guennadi >--- >Guennadi Liakhovetski, Ph.D. >Freelance Open-Source Software Developer >http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html