(dropped moderated "davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx" <davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx> ) On Thu, 25 Jun 2009, Karicheri, Muralidharan wrote: > > >-----Original Message----- > >From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > >owner@xxxxxxxxxxxxxxx] On Behalf Of Guennadi Liakhovetski > >Sent: Thursday, June 25, 2009 1:46 PM > >To: Karicheri, Muralidharan > >Cc: linux-media@xxxxxxxxxxxxxxx; davinci-linux-open- > >source@xxxxxxxxxxxxxxxxxxxx > >Subject: Re: [PATCH] mt9t031 - migration to sub device frame work > > > >On Wed, 24 Jun 2009, m-karicheri2@xxxxxx wrote: > > > >> From: Muralidharan Karicheri <m-karicheri2@xxxxxx> > >> > >> This patch migrates mt9t031 driver from SOC Camera interface to > >> sub device interface. This is sent to get a feedback about the > >> changes done since I am not sure if some of the functionality > >> that is removed works okay with SOC Camera bridge driver or > >> not. Following functions are to be discussed and added as needed:- > >> > >> 1) query bus parameters > >> 2) set bus parameters > >> 3) set crop > >> > >> I have tested this with vpfe capture driver and I could capture > >> 640x480@17fps and 2048x1536@12fps resolution frames from the sensor. > >> > >> Reviewed by: Hans Verkuil <hverkuil@xxxxxxxxx> > >> Reviewed by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > > >Excuse me? This is the first time I see this patch. FYI, "Reviewed-by" > >means that the respective person has actually reviewed the patch and > >submitted that line _him_ or _her_self! > > > >Thanks > >Guennadi > > > My mistake. I was assuming that by adding this line, I can get it > reviewed by the mandatory reviewers. Is there a way to provide this > information in the patch description? Yes, it should have been Cc: Potential Reviewer <reviewer@xxxxxxxxxxxx> and it would be useful to actually also cc those persons. > Could you please review this patch and give me the comments? I had > exchanged emails with you in the past agreeing to do this migration. I > remember you had accepted the same. Sure, I will. Hopefully tomorrow. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
