Hi Mauro,
On Mon, 15 Jun 2009, Mauro Carvalho Chehab wrote:
Em Thu, 11 Jun 2009 15:35:14 -0700 (PDT)
Trent Piepho <xyzzy@xxxxxxxxxxxxx> escreveu:
On Thu, 11 Jun 2009, Patrick Boettcher wrote:
On Wed, 27 May 2009, Trent Piepho wrote:
On Tue, 26 May 2009, Patrick Boettcher wrote:
Does this patch to fix these problems look ok?
In fact, everything looks correct in my eyes. I'll ask Mauro to pull any
minute from now.
I even have an explaination why the failing attach of the itd1000 was
not errored out: when I did the development I was using a userspace
proprietary driver to validate, for that I needed the demod to be
attached...
Thanks for cleaning up this mess.
Now that that patch is done, here is the rest of the series with dvb-pll
conversions. There is an additional patch to the flexcop card detecting
code. The #if defined(CONFIG_...) stuff didn't take into account code
being compiled into the kernel.
Here's the series:
01/08: dvb-pll: Add Samsung TDTC9251DH0 DVB-T NIM
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=3d148fee550b
02/08: dvb-pll: Add support for Samsung TBDU18132 DVB-S NIM
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=5a8e32e94aa7
03/08: dvb-pll: Add support for Samsung TBMU24112 DVB-S NIM
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=c28394056a5a
04/08: dvb-pll: Add support for Alps TDEE4 DVB-C NIM
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=90f54e498f90
05/08: b2c2: fix frontends compiled into kernel
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=748c762fcf3e
06/08: b2c2: Use dvb-pll for AirStar DVB-T's tuner
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=fcacc65753f1
07/08: b2c2: Use dvb-pll for Skystar2 rev 2.3 and rev 2.6
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8ef37f1432e6
08/08: b2c2: Use dvb-pll for Cablestar2
http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=01fd4e3bd1c0
Nice patches. Are those tested with real cards?
In particular, I loved this:
+/* Can we use the specified front-end? Remember that if we are compiled
+ * into the kernel we can't call code that's in modules. */
+#define FE_SUPPORTED(fe) (defined(CONFIG_DVB_##fe) || \
+ (defined(CONFIG_DVB_##fe##_MODULE) && defined(MODULE)))
IMO, you should add it on a dvb core header. Then, a cleanup patch would be to
simplify all those frontend tests all over all the dvb drivers code.
Patrick,
I think you have some skystar boards. I'd appreciate if you can review
those patches before applying it.
The only card I use which is using DVB_PLL (now) is the Airstar DVB-T. So
we need to take some risks and apply to force users to test :). I will ask
some users I know.
However I won't be able to commit nor test anything before 3.5 weeks
from now.
regards,
Patrick.
--
Mail: patrick.boettcher@xxxxxxx
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
