On Thu, 11 Jun 2009, Dongsoo, Nathaniel Kim wrote:
> Hello Guennadi,
>
> It's a very interesting patch. Actually some camera interfaces support
> for various image effects and I was wondering how to use them in SoC
> camera subsystem.
>
> But here is a question. Is it possible to make a choice with the same
> CID between icd and ici? I mean, if both of camera interface and
> camera device are supporting for same CID how can user select any of
> them to use? Sometimes, some image effects supported by camera
> interface are not good so I want to use the same effect supported by
> external camera ISP device.
>
> I think, it might be possible but I can't see how.
> > @@ -681,9 +698,16 @@ static int soc_camera_s_ctrl(struct file *file, void *priv,
> > struct soc_camera_file *icf = file->private_data;
> > struct soc_camera_device *icd = icf->icd;
> > struct soc_camera_host *ici = to_soc_camera_host(icd->dev.parent);
> > + int ret;
> >
> > WARN_ON(priv != file->private_data);
> >
> > + if (ici->ops->set_ctrl) {
> > + ret = ici->ops->set_ctrl(icd, ctrl);
> > + if (ret != -ENOIOCTLCMD)
> > + return ret;
> > + }
> > +
> > return v4l2_device_call_until_err(&ici->v4l2_dev, (__u32)icd, core, s_ctrl, ctrl);
> > }
Should be easy to see in the patch. Host's s_ctrl is called first. It can
return -ENOIOCTLCMD then sensor's control will be called too. Ot the host
may choose to call sensor's control itself, which, however, is
discouraged.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
