On Wednesday 10 June 2009 20:17:53 Guennadi Liakhovetski wrote: > On Tue, 9 Jun 2009, Hans Verkuil wrote: > > Hi Mauro, > > > > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-subdev2 > > for the following: > > > > - v4l2: add new s_config subdev ops and v4l2_i2c_new_subdev_cfg/board > > calls - v4l2-device: fix incorrect kernel check > > - v4l-compat: add I2C_ADDRS macro. > > - v4l2: update framework documentation. > > - v4l2-subdev: remove unnecessary check > > Do I understand this right, that these patches have not been posted to > the list? The idea is that you click on the link and look at the patches through the hg web frontend. > At least I haven't found them in online and in my local > archives. If it's really so, sorry, this doesn't seem very productive to > me... We have discussed this with Mauro on IRC, he didn't agree with me, > he thought it was acceptable in many cases... Sorry, cannot agree. Both methods (a pull request or a patch series) are used and personally I have no preference, although currently I have a script that simplifies these pull requests so I generally use that. A patch series makes it easier to reply with review comments, while I think a pull request reduces mailinglist traffic and actually makes it easier to do the actual reviews. Regards, Hans > > Thanks > Guennadi > > > This time I've only added new functions and left the existing ones in > > place. I did add a bit of code to the existing > > v4l2_i2c_new_(probed_)subdev functions to call the new s_config op if > > it is available. Existing subdev drivers never set this new op, so this > > code will not effect current behavior. But for new drivers that do set > > s_config it is important that it is called no matter what flavor of > > these functions is used. > > > > At the end of the 2.6.31 cycle we can replace the current > > v4l2_i2c_new_(probed_)subdev calls with the new one I had in my earlier > > patches. > > > > Thanks, > > > > Hans > > > > diffstat: > > linux/Documentation/video4linux/v4l2-framework.txt | 24 +++ > > linux/drivers/media/video/v4l2-common.c | 166 > > +++++++++++++++++++++ > > linux/drivers/media/video/v4l2-device.c | 2 > > linux/include/media/v4l2-common.h | 18 ++ > > linux/include/media/v4l2-subdev.h | 9 - > > v4l/compat.h | 6 > > 6 files changed, 222 insertions(+), 3 deletions(-) > > > > -- > > Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-media" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
