2009/6/9 Alexey Klimov <klimov.linux@xxxxxxxxx>: > Hello, Jean-Francois and Erik André > > What do you think about such small change? > Looks like the code doesn't need if-check and goto here in stv06xx_stopN > function. The code after label "out" does this. > > -- > Patch removes needless if check and goto. > > > Signed-off-by: Alexey Klimov <klimov.linux@xxxxxxxxx> Looks sane. Thank you for reporting. Best regards, Erik Reviewed-by: Erik Andrén <erik.andren@xxxxxxxxx> > -- > diff -r ed3781a79c73 linux/drivers/media/video/gspca/stv06xx/stv06xx.c > --- a/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Sat Jun 06 16:31:34 2009 +0400 > +++ b/linux/drivers/media/video/gspca/stv06xx/stv06xx.c Tue Jun 09 14:49:04 2009 +0400 > @@ -293,8 +293,6 @@ > goto out; > > err = sd->sensor->stop(sd); > - if (err < 0) > - goto out; > > out: > if (err < 0) > > > -- > Best regards, Klimov Alexey > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
