Re: [PATCH] V4L/pwc - use usb_interface as parent, not usb_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks good, we recently fixed the same issue in the gspca driver to,

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

On 06/04/2009 09:18 PM, Lennart Poettering wrote:
The current code creates a sysfs device path where the video4linux
device is child of the usb device itself instead of the interface it
belongs to. That is evil and confuses udev.

This patch does basically the same thing as Kay's similar patch for the
ov511 driver:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d

(Resent 2nd time, due to missing Signed-off-by)

Lennart

Signed-off-by: Lennart Poettering<mzxreary@xxxxxxxxxxx>
---
  drivers/media/video/pwc/pwc-if.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
index 7c542ca..92d4177 100644
--- a/drivers/media/video/pwc/pwc-if.c
+++ b/drivers/media/video/pwc/pwc-if.c
@@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
  		return -ENOMEM;
  	}
  	memcpy(pdev->vdev,&pwc_template, sizeof(pwc_template));
-	pdev->vdev->parent =&(udev->dev);
+	pdev->vdev->parent =&intf->dev;
  	strcpy(pdev->vdev->name, name);
  	video_set_drvdata(pdev->vdev, pdev);

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux