> From: Alan Cox <alan@xxxxxxxxxxxxxxx> > > The ivtv stream buffers may be for receive or for send but the attached sg > handle is always destined cpu->device. We flush it correctly but the > allocation is wrongly done with the same type as the buffers. > > See bug: http://bugzilla.kernel.org/show_bug.cgi?id=13385 > > (Note this doesn't close the bug - it fixes the ivtv part and in turn the > logging next shows up some rather alarming DMA sg list warnings in > libata) > > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx> Thanks for looking at this! 'Real-life' has been seriously interfering with my linux work lately so I didn't have the time to pick this up myself. Regards, Hans > --- > > drivers/media/video/ivtv/ivtv-queue.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > diff --git a/drivers/media/video/ivtv/ivtv-queue.c > b/drivers/media/video/ivtv/ivtv-queue.c > index ff7b7de..7fde36e 100644 > --- a/drivers/media/video/ivtv/ivtv-queue.c > +++ b/drivers/media/video/ivtv/ivtv-queue.c > @@ -230,7 +230,8 @@ int ivtv_stream_alloc(struct ivtv_stream *s) > return -ENOMEM; > } > if (ivtv_might_use_dma(s)) { > - s->sg_handle = pci_map_single(itv->pdev, s->sg_dma, sizeof(struct > ivtv_sg_element), s->dma); > + s->sg_handle = pci_map_single(itv->pdev, s->sg_dma, > + sizeof(struct ivtv_sg_element), PCI_DMA_TODEVICE); > ivtv_stream_sync_for_cpu(s); > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
