Em Wed, 3 Jun 2009 10:13:22 +0800
David Wong <davidtlwong@xxxxxxxxx> escreveu:
> Hi all,
>
> This ADMTV102 tuner code is grab from open sourced driver for
> MyCinema U3100 Mini DMB-TH from ASUS.
> I made some clean up to separate the tuner code from demod code.
>
> The original driver author cannot be reached, so I don't know should
> I declare the copyright.
This is probably the most important thing to do: we should be sure that
the driver doesn't have any licensing troubles, since you'll need to testify it
via Signed-off-by. So, if you couldn't find the original author, you may try to
reach the companies envolved, e. g. the distro kernel people, Asus and Analog
Device, asking for their SOB at the original driver.
Also, if the driver is authored by Oliver, as stated at the .h comment:
+ * Driver for Analog Device ADMTV102 silicon tuner
+ *
+ * Copyright (c) 2006 Olivier DANET <odanet@xxxxxxxxxxxx>
You should preserve his name at the meta-tags, instead of:
+MODULE_AUTHOR("David T.L. Wong");
(or, if you made significant changes, it is OK to add your name, without
suppressing the original author's name)
Another important point: when committing such drivers, the better is to add the
first patch (without Kconfig/Makefile changes) as-is, and then write a second
patch with your changes. This helps to have a clearer boundary line about your
contributions. The last patch should be the Kconfig/Makefile changes. This
helps to avoid trying to build a driver that may not compile well, due to some
API changes, for example, that needs to be fixed during the upstream merging
phase.
> Please comment.
>
> Regards,
> David T.L. Wong
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
