On Mon, 2009-06-01 at 17:20 +0200, Patch from Mauro Carvalho Chehab wrote: > The patch number 11917 was added via Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > to http://linuxtv.org/hg/v4l-dvb master development tree. > > Kernel patches in this development tree may be modified to be backward > compatible with older kernels. Compatibility modifications will be > removed before inclusion into the mainstream Kernel > > If anyone has any objections, please let us know by sending a message to: > Linux Media Mailing List <linux-media@xxxxxxxxxxxxxxx> > > ------ > > From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Fix firmware load for DVB-T @ 6MHz > > > bandwidth for xc3028/xc3028L > > > The only two countries that are known to use 6MHz bandwidth are Taiwan > and Uruguay. Both use QAM subcarriers at OFTM. > > This patch fixes the firmware load for such countries, where the > required firmware is the QAM one. > > This also confirms the previous tests where it was noticed that the 6MHz > QAM firmware doesn't work for cable. So, this patch also removes support > for DVB-C, instead of just printing a warning. > > Thanks to Terry Wu <terrywu2009@xxxxxxxxx> for pointing this issue and > to Andy Walls <awalls@xxxxxxxxx> for an initial patch for this fix. > > Priority: normal > > CC: Terry Wu <terrywu2009@xxxxxxxxx> > CC: Andy Walls <awalls@xxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Acked-by: Andy Walls <awalls@xxxxxxxxx> I looks like it accomplishes the 6 MHz DVB-T support in xc2028_set_params() that Terry needed. I personally wouldn't have disabled the FE_QAM stuff. However it doesn't matter as far as current Linux driver use of the XC3028 is concerned - no driver currently sets up the XC3028 with a DVB-C demod. Regards, Andy > --- > > linux/drivers/media/common/tuners/tuner-xc2028.c | 17 +++++++-------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff -r d55ec37bebfa -r c78c18fe3dc9 linux/drivers/media/common/tuners/tuner-xc2028.c > --- a/linux/drivers/media/common/tuners/tuner-xc2028.c Mon Jun 01 05:22:37 2009 -0300 > +++ b/linux/drivers/media/common/tuners/tuner-xc2028.c Mon Jun 01 11:46:08 2009 -0300 > @@ -1026,21 +1026,20 @@ static int xc2028_set_params(struct dvb_ > switch(fe->ops.info.type) { > case FE_OFDM: > bw = p->u.ofdm.bandwidth; > - break; > - case FE_QAM: > - tuner_info("WARN: There are some reports that " > - "QAM 6 MHz doesn't work.\n" > - "If this works for you, please report by " > - "e-mail to: v4l-dvb-maintainer@xxxxxxxxxxx\n"); > - bw = BANDWIDTH_6_MHZ; > - type |= QAM; > + /* > + * The only countries with 6MHz seem to be Taiwan/Uruguay. > + * Both seem to require QAM firmware for OFDM decoding > + * Tested in Taiwan by Terry Wu <terrywu2009@xxxxxxxxx> > + */ > + if (bw == BANDWIDTH_6_MHZ) > + type |= QAM; > break; > case FE_ATSC: > bw = BANDWIDTH_6_MHZ; > /* The only ATSC firmware (at least on v2.7) is D2633 */ > type |= ATSC | D2633; > break; > - /* DVB-S is not supported */ > + /* DVB-S and pure QAM (FE_QAM) are not supported */ > default: > return -EINVAL; > } > > > --- > > Patch is available at: http://linuxtv.org/hg/v4l-dvb/rev/c78c18fe3dc9f1338a589130c4eeed14c1d90b44 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
