Trent Piepho píše v Ne 31. 05. 2009 v 06:34 -0700: > Instead of raising the reset line here, why not change the gpio settings in > the card definition to have it high? Change gpio1 for television to 0x7050 > and radio to 0x7010. Personally, I don't know when these .gpioX members are used (before firmware loads or after...). But I assume that adding the high on reset pin shouldn't break anything, so we can do this. > Then the reset can be done with: > > case XC2028_TUNER_RESET: > /* GPIO 12 (xc3028 tuner reset) */ > cx_write(MO_GP1_IO, 0x101000); > mdelay(50); > cx_write(MO_GP1_IO, 0x101010); > mdelay(50); > return 0; > > Though I have to wonder why each card needs its own xc2028 reset function. > Shouldn't they all be the same other than what gpio they change? > > > @@ -2882,6 +2946,16 @@ > cx_set(MO_GP0_IO, 0x00000080); /* 702 out of reset */ > udelay(1000); > break; > + > + case CX88_BOARD_WINFAST_DTV1800H: > + /* GPIO 12 (xc3028 tuner reset) */ > + cx_set(MO_GP1_IO, 0x1010); > + mdelay(50); > + cx_clear(MO_GP1_IO, 0x10); > + mdelay(50); > + cx_set(MO_GP1_IO, 0x10); > + mdelay(50); > + break; > } > } > > Couldn't you replace this with: > > case CX88_BOARD_WINFAST_DTV1800H: > cx88_xc3028_winfast1800h_callback(code, XC2028_TUNER_RESET, 0); > break; > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
