Hello Eduardo, On Wed, 27 May 2009 12:35:47 +0300 Eduardo Valentin <eduardo.valentin@xxxxxxxxx> wrote: > Hello all, > > I'm resending the FM transmitter driver and the proposed changes in > v4l2 api files in order to cover the fmtx extended controls class. > > It is basically the same series of version #3. However I rewrote it > to add the following comments: > > * Check kernel version for i2c helper function. Now the board data > is passed not using i2c_board_info. This way all supported kernel > versions can use the api. Besides that, the .s_config callback was > added in core ops. > > * All patches are against v4l-dvb hg repository. > > Again, comments are welcome. I have a comment, please check some headers to avoid errors. Instead of: patch 05: #include <media/linux/v4l2-device.h> #include <media/linux/v4l2-ioctl.h> #include <media/linux/v4l2-i2c-drv.h> #include <media/linux/v4l2-subdev.h> patch 06: #include <media/linux/v4l2-device.h> #include <media/linux/v4l2-common.h> #include <media/linux/v4l2-ioctl.h> Please use: #include <media/v4l2-device.h> #include <media/v4l2-ioctl.h> #include <media/v4l2-i2c-drv.h> #include <media/v4l2-subdev.h> and #include <media/v4l2-device.h> #include <media/v4l2-common.h> #include <media/v4l2-ioctl.h> Cheers, Douglas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
