On Thu, 21 May 2009, Hans Verkuil wrote: > On Friday 15 May 2009 19:20:18 Guennadi Liakhovetski wrote: > > NOT FOR SUBMISSION. Probably, another solution has to be found. > > soc-camera drivers need an .init() (marked as "don't use") and a .halt() > > methods. > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > --- > > > > Hans, you moved s_standby to tuner_ops, and init is not recommended for > > new drivers. Suggestions? > > Usual question: why do you need an init and halt? What do they do? Hm, maybe you're right, I don't need them. init() was used in soc_camera drivers on first open() to possibly reset the chip and put it in some reasonably pre-defined low-power state. But we can do this at the end of probe(), which even would be more correct, because even the first open should not change chip's configuration. And halt() (was called release() originally) is called on last close(). And it seems you shouldn't really do this at all - the chip should preserve its configuration between open/close cycles. Am I right? Does anyone among cc'ed authors have any objections against this change? The actual disable should indeed migrate to some PM functions, if implemented. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
