Hi Hans, On Thu, 21 May 2009, Hans Verkuil wrote: > On Friday 15 May 2009 19:20:10 Guennadi Liakhovetski wrote: > > Introduce a function similar to v4l2_i2c_new_subdev() but taking a > > pointer to a struct i2c_board_info as a parameter instead of a client > > type and an I2C address, and make v4l2_i2c_new_subdev() a wrapper around > > it. > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > --- > > > > Hans, renamed as you requested and updated to a (more) current state. > > NAK. Not because it is a bad idea, but because you need to patch against the > version in the v4l-dvb repo. The version in the kernel is missing a lot of > the compatibility code which we unfortunately need to keep. > > Any function passing the board_info will be valid for kernels >= 2.6.26 > only. Here's a quote from your earlier email. On Tue, 21 Apr 2009, Hans Verkuil wrote: > The board_info struct didn't appear until 2.6.22, so that's certainly a > cut-off point. Since the probe version of this call does not work on > kernels < 2.6.26 the autoprobing mechanism is still used for those older > kernels. I think it makes life much easier to require that everything that > uses board_info needs kernel 2.6.26 at the minimum. I don't think that is > an issue anyway for soc-camera. Unless there is a need to use soc-camera > from v4l-dvb with kernels <2.6.26? So, will this my patch build and work with >= 2.6.22 or not? I really would not like to consciously make code uglier now because of compatibility with < 2.6.26 to make it better some time later again. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
