Re: [patch 1/4] radio-mr800.c: missing mutex include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Wed, May 13, 2009 at 12:39 AM,  <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> From: Alessio Igor Bogani <abogani@xxxxxxxxxx>
>
> radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> pulled in indirectly by one of the headers it already includes, the right
> thing is to include it directly.
>
> Signed-off-by: Alessio Igor Bogani <abogani@xxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
>  drivers/media/radio/radio-mr800.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff -puN drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include drivers/media/radio/radio-mr800.c
> --- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include
> +++ a/drivers/media/radio/radio-mr800.c
> @@ -64,6 +64,7 @@
>  #include <media/v4l2-ioctl.h>
>  #include <linux/usb.h>
>  #include <linux/version.h>     /* for KERNEL_VERSION MACRO */
> +#include <linux/mutex.h>
>
>  /* driver and module definitions */
>  #define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@xxxxxxxxx>"
> _

There was discussion about this patch.
http://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg03556.html

Well, i'm not against this patch.

-- 
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux