Devin Heitmueller wrote: > On Wed, May 13, 2009 at 2:52 AM, Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > > On Wed, 13 May 2009, Oliver Endriss wrote: > >> 02/05: dvb-ttpci: Check transport error indicator flag > >> http://endriss@xxxxxxxxxxx/hg/~endriss/v4l-dvb?cmd=changeset;node=8a742338523d > > > > Are you sure this is a good idea? The cx88 driver doesn't do this. > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-media" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > I agree with Trent on this one - dropping the packet at the hardware > level is a bad idea. If the demodulator is incapable of setting the > TEI bit (which most do) and you are forced to rely on the TSERR line, > then you should be marking the TEI bit and passing the packet on. > Dropping the packet at the hardware level is likely to cause confusion > for app developers (why am I only getting 60% of the expected > packets?) What are you talking about? This patch does not have any impact on the reception path (from tuner to application). It just discards bogus data which might crash the av7110 or cause chirping sound during replay. > Like I said above though, in most cases I've seen the demod does all > the work and there is no need to act on the TSERR line at all. See above. Oliver -- ---------------------------------------------------------------- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ ---------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
