Em Tue, 12 May 2009 17:18:20 -0400 Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> escreveu: > On Tue, May 12, 2009 at 4:39 PM, <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > From: Roel Kluin <roel.kluin@xxxxxxxxx> > > > > Fix &&/|| typo. `default_norm' can be 0 (PAL), 1 (NTSC) or 2 (SECAM), > > the condition tested was impossible. > > > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > > Cc: Hans Verkuil <hverkuil@xxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > --- > > Hello, > > Was the patch actually tested against the hardware in question? While > I agree that it looks ok, it can result in the default logic being > inverted in some cases, which could expose other bugs and result in a > regression. > > I just want to be confident that this patch was tested by somebody > with the hardware and it isn't going into the codebase because "it > obviously cannot be right". Hans and Jean worked on it. Both are at PAL area, so they won't notice such error without a standards generator, since the default is to assume that the signal is PAL. With this patch, PAL should keep working, but I can't see how NTSC or SECAM would work without it. Anyway, this patch were already committed on our tree, and it is on my linux-next tree since yesterday night. Hans, Could you please confirm that the patch is ok with your standards generator? Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
