Hi Eero,
On Tue, May 12, 2009 at 06:49:25AM +0200, Nurkkala Eero.An (EXT-Offcode/Oulu) wrote:
> On Mon, 2009-05-11 at 11:31 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote:
> > +enum v4l2_fmtx_preemphasis {
> > + V4L2_FMTX_PREEMPHASIS_75_uS = 0,
> > + V4L2_FMTX_PREEMPHASIS_50_uS = 1,
> > + V4L2_FMTX_PREEMPHASIS_DISABLED = 2,
> > +};
>
> Hello there,
>
> Would it make more sense to make:
> "V4L2_FMTX_PREEMPHASIS_DISABLED" as "zero" (false). In my opinion,
> that would be more clear.
Indeed,
Something like:
enum v4l2_fmtx_preemphasis {
V4L2_FMTX_PREEMPHASIS_DISABLED = 0,
V4L2_FMTX_PREEMPHASIS_50_uS = 1,
V4L2_FMTX_PREEMPHASIS_75_uS = 2,
};
looks better?
>
> - Eero
--
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
