Re: [PULL] http://linuxtv.org/hg/~stoth/tda10048

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Tue, 05 May 2009 17:41:55 -0400
Steven Toth <stoth@xxxxxxxxxxx> escreveu:

> Mauro,
> 
> Please pull from http://www.linuxtv.org/hg/~stoth/tda10048
> 
>     -  tda10048: Add ability to select I/F at attach time.

+       /* avoid warning: this decimal constant is unsigned only in ISO C90 */
+       /* t *= 2147483648 on 32bit platforms */
+       t *= (2048 * 1024);
+       t *= 1024;
+       z = 7 * sample_freq_hz;

You get the warning because you haven't properly specified the constant. So, instead of doing:
	t *= 2147483648
You should properly specified the constant with "u", "l", or "L". Something like:
	t *= 2147483648ul

Or, even better:
	t *= 1u << 31

I've applied what we have, but, IMO, you should replace the above code by "1u <<
31" since this indicates better what you want to do.




Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux