Good comments. Only ISP driver is based on the V4L2 driver framework. The camera sensor used on the Moorestown platform is based on the I2C client driver. I will look at the Documentation/video4linux/v4l2-framework.txt and will consider your comment in our future plan. Welcome any more comments. Thanks, Xiaolin -----Original Message----- From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media-owner@xxxxxxxxxxxxxxx] On Behalf Of Hans Verkuil Sent: Saturday, May 02, 2009 11:43 PM To: Guennadi Liakhovetski Cc: Zhang, Xiaolin; linux-media@xxxxxxxxxxxxxxx; Johnson, Charles F; Zhu, Daniel Subject: Re: [PATCH 0/5] V4L2 patches for Intel Moorestown Camera Imaging Drivers On Friday 01 May 2009 23:26:02 Guennadi Liakhovetski wrote: > On Thu, 30 Apr 2009, Zhang, Xiaolin wrote: > > Hi All, > > > > Here is the a set of V4L2 camera sensors and ISP drivers to support the > > Intel Moorestown camera imaging subsystem. The Camera Imaging interface > > in Moorestown is responsible for capturing both still and video frames. > > The CI handles demosaicing, color synthesis, filtering, image > > enhancement functions and JPEG encode. Intel Moorestown platform can > > support either a single camera or two cameras. A platform with two > > cameras will have on the same side as this display and the second on > > the opposite side the display. The camera on the display side will be > > used for video conferencing (with low resolution SoC cameras) and the > > other camera is used to still image capture or video recode (with high > > resolution RAW cameras). > > > > In this set of driver patches, I will submit the 5 patches to enable > > the ISP HW and 3 cameras module (two SoCs: 1.3MP - Omnivision 9665, 2MP > > - Omnivison 2650 and one RAW: 5MP - Omnivision 5630). > > 1. Intel Moorestown ISP driver. > > 2. Intel Moorestown camera sensor pseudo driver. This is to uniform the > > interfaces for ISP due to supporting dual cameras. > > 3. Intel Moorestown 2MP camera sensor driver. > > 4. Intel Moorestown 5MP camera sensor driver. > > 5. Intel Moorestown 1.3MP camera sensor driver. > > > > I will post the above 5 patches in near feature. > > I think this is a perfect candidate for the use of the v4l2-(sub)dev API, > and should be converted to use it, am I right? Absolutely. The sensor drivers must use v4l2_subdev, otherwise they will not be reusable by other drivers. There is a lot of work that needs to be done before these sensor drivers can be merged. These sensor drivers are tightly coupled to the platform driver, thus preventing any reuse of these i2c devices. That's bad and something that needs to be fixed first. Xiaolin, please take a look at Documentation/video4linux/v4l2-framework.txt for information on the new v4l2 framework. All v4l2 i2c drivers should use v4l2_subdev to enable reuse of these i2c devices in other platform drivers and webcams. Regards, Hans > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
