On Thursday 23 April 2009 13:35:02 Mauro Carvalho Chehab wrote: > On Sun, 19 Apr 2009 12:46:00 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > > Hi Mauro, > > > > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-davinci for the > > following: > > > > - v4l: TI THS7303 video amplifier driver code > > +static int ths7303_setvalue(struct v4l2_subdev *sd, v4l2_std_id std) > +{ > + int err = 0; > + u8 val; > + struct i2c_client *client; > + > + client = v4l2_get_subdevdata(sd); > + > + if ((std & V4L2_STD_NTSC) || (std & V4L2_STD_PAL)) { > + val = 0x02; > + v4l2_dbg(1, debug, sd, "setting value for SDTV format\n"); > + } else { > + val = 0x00; > + v4l2_dbg(1, debug, sd, "disabling all channels\n"); > + } > + > > Hmm... Are you sure that the above check is ok? The standards you're allowing > are: PAL/BGDKHI and NTSC (except for NTSC/443). So, standards like PAL/N, > PAL/N', PAL/60, PAL/M will stay away. > > If what you want is all standards but SECAM, then the correct syntax would be something like: > if (std & (V4L2_STD_ALL & ~V4L2_STD_SECAM)) > > > - Analog Devices ADV7343 video encoder driver > > +#define SD_STD_NTSC (0x00) > +#define SD_STD_PAL_BDGHI (0x01) > +#define SD_STD_PAL_M (0x02) > +#define SD_STD_PAL_N (0x03) > > Hmm... from the comments at the beginning of the .c file, it seems that the > hardware supports all standards but SECAM. The above register definitions also > specifies PAL/M and PAL/M as supported standards. > > However, by looking at the std_into table: > > +static const struct adv7343_std_info > + adv7343_composite_std_info[] = { > + { > + SD_STD_NTSC, 0x1F, 0x7C, 0xF0, 0x21, V4L2_STD_NTSC, > + }, > + { > + SD_STD_PAL_BDGHI, 0xCB, 0x8A, 0x09, 0x2A, V4L2_STD_PAL, > + }, > +}; > + > +static const struct adv7343_std_info > + adv7343_component_std_info[] = { > + { > + SD_STD_NTSC, 0x1F, 0x7C, 0xF0, 0x21, V4L2_STD_NTSC, > + }, > + { > + SD_STD_PAL_BDGHI, 0x1F, 0x7C, 0xF0, 0x21, V4L2_STD_PAL, > + }, > +}; > > Hmm.. on the last table, you are using a FSC = 3,579,545.45 Hz for both PAL and > NTSC? This seems wrong to my eyes. > > Also, both tables have several supported standards missed. Mauro, Are there TVs in Brazil that are unable to handle standard NTSC-M on the composite or S-Video inputs? There are no encoders in v4l-dvb that do something special for PAL-M. All just check against 525 vs 625 line standards. And I can't imagine that that will cause problems for Brazilian TVs. I think these drivers should just use V4L2_STD_525_60 and V4L2_STD_625_50, just like saa7127 does. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
