> On Tue, 21 Apr 2009, Hans Verkuil wrote:
>
>>
>> > On Tue, 21 Apr 2009, Hans Verkuil wrote:
>> >
>> >>
>> >> > Video (sub)devices, connecting to SoCs over generic i2c busses
>> cannot
>> >> > provide a pointer to struct v4l2_device in i2c-adapter driver_data,
>> >> and
>> >> > provide their own i2c_board_info data, including a platform_data
>> >> field.
>> >> > Add a v4l2_i2c_new_dev_subdev() API function that does exactly the
>> >> same as
>> >> > v4l2_i2c_new_subdev() but uses different parameters, and make
>> >> > v4l2_i2c_new_subdev() a wrapper around it.
>> >>
>> >> Huh? Against what repository are you compiling? The v4l2_device
>> pointer
>> >> has already been added!
>> >
>> > Ok, have to rebase then. I guess, it still would be better to do the
>> way I
>> > propose in this patch - to add a new function, with i2c_board_info as
>> a
>> > parameter and convert v4l2_i2c_new_subdev() to a wrapper around it,
>> than
>> > to convert all existing users, agree? Do you also agree with the name?
>>
>> I like the idea of passing in a board_info struct instead of an
>> addr/client_type.
>
> And converting v4l2_i2c_new_subdev() to a wrapper is ok too?
Sure.
>> Just make sure when preparing a patch for the v4l-dvb
>> repo that this new function is for kernels >= 2.6.26 only.
>
> Why and how? I am not adding any new structs or fields with this patch, am
> I? So it should build with all kernels, with which the current
> v4l2_i2c_new_subdev() builds.
The board_info struct didn't appear until 2.6.22, so that's certainly a
cut-off point. Since the probe version of this call does not work on
kernels < 2.6.26 the autoprobing mechanism is still used for those older
kernels. I think it makes life much easier to require that everything that
uses board_info needs kernel 2.6.26 at the minimum. I don't think that is
an issue anyway for soc-camera. Unless there is a need to use soc-camera
from v4l-dvb with kernels <2.6.26?
Regards,
Hans
>> I prefer a name like v4l2_i2c_subdev_board(). I will probably at some
>> stage remove that '_new' part of the existing functions anyway as that
>> doesn't add anything to the name.
>
> Ok, will do.
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
