Re: Siano's patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 5 Apr 2009 07:19:59 -0700 (PDT)
Uri Shkolnik <urishk@xxxxxxxxx> wrote:

> 
>  Hi Mauro,
>  
>  
>  Please note patches (1..19) series @ http://patchwork.kernel.org/project/linux-media/list/?submitter=uri
>  
>  I'll wait for reviews and commit for this series before submitting additional patches.

Uri,

I've finished reviewing and applying the patches. I had to skip some patches,
since they don't apply without some previous patches that I asked for changes.

Please re-submit those missing patches later.

I strongly suggest that you submit first all the patches that changes only
CodingStyle, and wait for my review before sending other patches (or otherwise
let them to happen only after merging all other patches).

In general, such patches won't generate discussions, provided
that checkpatch.pl doesn't complain, and that you manually review the results
of automatic tools like indent (that, in some cases, cause CodingStyle
regressions - such tool should be used with care).

The rationale is that patches that touches on CodingStyle replaces things on
almost everywhere. If a patch with CodingStyle changes got rejected by some
reason, the subsequent patches won't apply and will also be rejected.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux