On Mon, 20 Apr 2009 09:40:42 -0700 (PDT) Uri Shkolnik <urishk@xxxxxxxxx> wrote: > > > > --- On Mon, 4/20/09, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote: > > > From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > > Subject: Re: [PATCH] [0904_1] Siano: core header - update license and include files > > To: "Uri Shkolnik" <urishk@xxxxxxxxx> > > Cc: linux-media@xxxxxxxxxxxxxxx > > Date: Monday, April 20, 2009, 5:42 PM > > On Sun, 5 Apr 2009 01:09:16 -0700 > > (PDT) > > Uri Shkolnik <urishk@xxxxxxxxx> > > wrote: > > > > > > > > # HG changeset patch > > > # User Uri Shkolnik <uris@xxxxxxxxxxxx> > > > # Date 1238689930 -10800 > > > # Node ID c3f0f50d46058f07fb355d8e5531f35cfd0ca37e > > > # Parent > > 7311d23c3355629b617013cd51223895a2423770 > > > [PATCH] [0904_1] Siano: core header - update license > > and included files > > > > > > From: Uri Shkolnik <uris@xxxxxxxxxxxx> > > > > > > This patch does not include any implementation > > changes. > > > It update the smscoreapi.h license to be identical to > > > > > other Siano's headers and the #include files list. > > > > s/update/updates/ > > > > > #include <linux/version.h> > > > #include <linux/device.h> > > > @@ -28,15 +28,23 @@ > > > #include <linux/mm.h> > > > #include <linux/scatterlist.h> > > > #include <linux/types.h> > > > +#include <linux/mutex.h> > > > +#include <linux/compat.h> > > > +#include <linux/wait.h> > > > +#include <linux/timer.h> > > > + > > > #include <asm/page.h> > > > -#include <linux/mutex.h> > > > -#include "compat.h" > > > > Hmm... Why do you need the above changes? Also, #include > > "compat.h" is > > required, in order to compile inside the out-of-tree kernel > > tree. > > > > Also, the header changes should be on a different > > changeset, since they aren't > > related to what's described, e. g. this has nothing to do > > with licensing change. > > > > > > Cheers, > > Mauro > > > > 1) "compat.h" became <linux/compat.h> as result of old ML review > ---> +#include <linux/compat.h> I have no idea when do you need to include linux/compat.h. However, as compilation is currently fine, I see no reasons why to add it. I also don't have any idea why do you need to add other include files, since it is properly compiling without adding any other header. In the case of "compat.h", this is local to the out-of-tree compilation, having some needed defines to compile against older kernel versions. This header it is automatically stripped from upstream changes. > 2) There were a mail exchanged, back in mid-summer 2008, regarding the license. One template has been approved both by Siano and the reviewers back then, and the patch comes the align this particular file with that old decision. This seems fine to my eyes. > Regarding the change-set - since there were no implementation changes (only license text modification and re-arranging the include files list (I hadn't counted "compat.h" --> <linux/compat.h> as an implementation change) I decided to put them in one patch. If higher resolution is needed, I'll do so, If all you're doing is rearranging, it would be fine to add it at the same changeset, but you should explicitly mention this at the description. Also, fyi, the proper include sequence is: 1) Include all kernel headers that aren't at -hg (no particular order here - I generally use some alphabetic order, but this is just my personal preference); 2) #include "compat.h" 3) The other v4l/dvb core headers and local headers. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
