Re: [PATCH] [0904_1] Siano: core header - update license and include files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 5 Apr 2009 01:09:16 -0700 (PDT)
Uri Shkolnik <urishk@xxxxxxxxx> wrote:

> 
> # HG changeset patch
> # User Uri Shkolnik <uris@xxxxxxxxxxxx>
> # Date 1238689930 -10800
> # Node ID c3f0f50d46058f07fb355d8e5531f35cfd0ca37e
> # Parent  7311d23c3355629b617013cd51223895a2423770
> [PATCH] [0904_1] Siano: core header - update license and included files
> 
> From: Uri Shkolnik <uris@xxxxxxxxxxxx>
> 
> This patch does not include any implementation changes.
> It update the smscoreapi.h license to be identical to 
> other Siano's headers and the #include files list.

s/update/updates/

>  #include <linux/version.h>
>  #include <linux/device.h>
> @@ -28,15 +28,23 @@
>  #include <linux/mm.h>
>  #include <linux/scatterlist.h>
>  #include <linux/types.h>
> +#include <linux/mutex.h>
> +#include <linux/compat.h>
> +#include <linux/wait.h>
> +#include <linux/timer.h>
> +
>  #include <asm/page.h>
> -#include <linux/mutex.h>
> -#include "compat.h"

Hmm... Why do you need the above changes? Also, #include "compat.h" is
required, in order to compile inside the out-of-tree kernel tree.

Also, the header changes should be on a different changeset, since they aren't
related to what's described, e. g. this has nothing to do with licensing change.


Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux