On Sun, 19 Apr 2009, Antti Palosaari wrote:
Armin Schenker kirjoitti:
- .num_device_descs = 11,
+ .num_device_descs = 12,
- struct dvb_usb_device_description devices[11];
+ struct dvb_usb_device_description devices[12];
I don't comment about this patch but general.
I didn't realized this value is allowed to increase when adding new devices.
Due to that there is now three dvb_usb_device_properties in af9015 which
makes driver a little bit complex.
What we should do? Can I remove code from af9015 and increase
dvb_usb_device_description count to about 30? What is biggest suitable value
we want use, how much memory one entry will take.
One dvb_usb_device_description is (2*15+1) * pointer-size. For
PC-architecture it seems not big for me, but for other architectures it
can be a problem.
After 4 years in place I think we could evaluate whether another method
for the module_device_id-table in all those dvb-usb-modules cannot be made
differently, best case, without any fixed array-sizes.
One very convenient option would be the driver_info-field in the
usb_device_id-table, but it will be hard to convert all drivers and to
keep some information we have today (like the device name) at the same
time .
Beside the size-problem there is still the issue of having the fixed
indexes referenced by the dvb_usb_device_descriptor.
No matter how I think about it, I still have such a link between the
mod_id_table and the dvb_usb_device_description.
If someone comes up with a good idea how to replace the current way of
doing things, it'll be more than welcome. :)
Patrick.
--
Mail: patrick.boettcher@xxxxxxx
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
