Re: [PATCH 0/5] soc-camera: convert to platform device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 17, 2009 at 7:43 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> On Fri, 17 Apr 2009, Magnus Damm wrote:
>> On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski
>> <g.liakhovetski@xxxxxx> wrote:
>> > On Fri, 17 Apr 2009, Magnus Damm wrote:
>> >> On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski
>> >> <g.liakhovetski@xxxxxx> wrote:
>> >> > This patch series is a preparation for the v4l2-subdev conversion. Please,
>> >> > review and test. My current patch-stack in the form of a
>> >> > (manually-created) quilt-series is at
>> >> > http://www.open-technology.de/download/20090415/ based on linux-next
>> >> > history branch, commit ID in 0000-base file. Don't be surprised, that
>> >> > patch-set also contains a few not directly related patches.
>> >>
>> >> Testing on Migo-R board with 2.6.30-rc2-git-something and the
>> >> following cherry-picked patches:
>> >>
>> >> 0007-driver-core-fix-driver_match_device.patch
>> >> 0033-soc-camera-host-driver-cleanup.patch
>> >> 0034-soc-camera-remove-an-extra-device-generation-from-s.patch
>> >> 0035-soc-camera-simplify-register-access-routines-in-mul.patch
>> >> and part of 0036 (avoiding rejects, ap325 seems broken btw)
>> >
>> > Have I broken it or is it unrelated?
>>
>> 2.6.30-rc seems broken on Migo-R. A quick check suggests the following:
>
> Ok, before we come to Migo-R, what is with ap325? Have I broken it with
> this my series or is it a different problem?

Not sure. I used 2.6.30-rc but I guess your patches are aimed at linux-next.

>> V4L/DVB (10141): OK
>> V4L/DVB (10672): BAD
>> V4L/DVB (11024): BAD
>
> These seem to be pretty random snapshots... Are they all on Linus' master
> or on next or on v4l-dvb? You did pick up the
>
> 0007-driver-core-fix-driver_match_device.patch

Yeah, I tried that one. I'm not sure what was the problem, but it's gone now.

Today I've tested the following on top of linux-2.6 (stable 2.6.30-rc)
d91dfbb41bb2e9bdbfbd2cc7078ed7436eab027a

0033-soc-camera-host-driver-cleanup.patch
0034-soc-camera-remove-an-extra-device-generation-from-s.patch
0035-soc-camera-simplify-register-access-routines-in-mul.patch

So far OK.
However, applying 0036- or v2 from the mailing list results in rejects
(probably because linux-next vs linux-2.6 differences) but the files
should not affect Migo-R.

So with 0036 or v2 applied it builds ok for Migo-R, but I can't open
/dev/video0 for some reason. Reverting the patch and only using
0033->0035 above results in ok /dev/video0 opening.

What are your dependencies?

I'll try out your 20090415/series on top of the matching linux-next for now.

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux