On Thu, 2009-04-16 at 08:34 -0500, Aguirre Rodriguez, Sergio Alberto wrote: > Hi, > > During the omap3camera development, we came across with the case of > imaging sensors which can produce test patterns instead of capturing > images from the CCD. > > What we did in an attempt to keep an standard interface, is that we > created a CID named V4L2_CID_TEST_PATTERN of integer type, so 0 is "no > test pattern", and from 1 to any supported quantity, to select between > supported pattern modes. Maybe instead of an integer (V4L2_CTRL_TYPE_INTEGER), you could use a menu type control (V4L2_CTRL_TYPE_MENU) and present meaningful, driver specific names to the user of the control. There are a few modules under linux/driver/media/video/ that use it. I'm familiar with ivtv and cx18 but their implementation is split with some common parts in the cx2341x module, so they may not be the easiest example to follow. Maybe the cpia2 module would be a simpler example of menu controls to look at. > So, do you think this is good approach? Or is it something which > supports already this kind of setting? I think it is a pretty common > feature in capturing devices. cx18 & ivtv have a video_mute boolean control, and a video_mute_yuv integer control: essentially a simple test pattern controlled by a pair of user controls. So I think you already have a precedent. Regards, Andy > Regards, > Sergio -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
