On 4/13/2009 10:46 AM, Joonyoung Shim wrote: > On 4/13/2009 5:56 AM, Tobias Lorenz wrote: >> Hi Joonyoung, >> >> Hi Alexey, >> >> I've split the driver into a couple of segments: >> >> - radio-si470x-common.c is for common functions >> >> - radio-si470x-usb.c are the usb support functions >> >> - radio-si470x-i2c.c is an untested prototyped file for your i2c support >> functions >> >> - radio-si470x.h is a header file with everything required by the c-files >> >> I hope this is a basis we can start on with i2c support. What do you think? >> >> The URL is: >> >> http://linuxtv.org/hg/~tlorenz/v4l-dvb > > It looks good, i will test with implementing the i2c functions. I compiled getting your source from above URL, but i could not compile because of supporting only usb compilation at Makefile. I suggest to modify at Kconfig and Makefile like following patch. What do you think? diff -r 43d455adb02c linux/drivers/media/radio/Makefile --- a/linux/drivers/media/radio/Makefile Sun Apr 12 22:51:40 2009 +0200 +++ b/linux/drivers/media/radio/Makefile Mon Apr 13 14:31:05 2009 +0900 @@ -17,7 +17,7 @@ obj-$(CONFIG_RADIO_TRUST) += radio-trust.o obj-$(CONFIG_RADIO_MAESTRO) += radio-maestro.o obj-$(CONFIG_USB_DSBR) += dsbr100.o -obj-$(CONFIG_USB_SI470X) += si470x/ +obj-$(CONFIG_RADIO_SI470X) += si470x/ obj-$(CONFIG_USB_MR800) += radio-mr800.o obj-$(CONFIG_RADIO_TEA5764) += radio-tea5764.o diff -r 43d455adb02c linux/drivers/media/radio/si470x/Kconfig --- a/linux/drivers/media/radio/si470x/Kconfig Sun Apr 12 22:51:40 2009 +0200 +++ b/linux/drivers/media/radio/si470x/Kconfig Mon Apr 13 14:31:05 2009 +0900 @@ -1,6 +1,10 @@ +config RADIO_SI470X + tristate "Silicon Labs Si470x FM Radio Receiver support" + depends on VIDEO_V4L2 + config USB_SI470X tristate "Silicon Labs Si470x FM Radio Receiver support with USB" - depends on USB && VIDEO_V4L2 + depends on USB && RADIO_SI470X ---help--- This is a driver for USB devices with the Silicon Labs SI470x chip. Currently these devices are known to work: @@ -25,7 +29,7 @@ config I2C_SI470X tristate "Silicon Labs Si470x FM Radio Receiver support with I2C" - depends on I2C && VIDEO_V4L2 + depends on I2C && RADIO_SI470X ---help--- This is a driver for I2C devices with the Silicon Labs SI470x chip. diff -r 43d455adb02c linux/drivers/media/radio/si470x/Makefile --- a/linux/drivers/media/radio/si470x/Makefile Sun Apr 12 22:51:40 2009 +0200 +++ b/linux/drivers/media/radio/si470x/Makefile Mon Apr 13 14:31:05 2009 +0900 @@ -2,8 +2,8 @@ # Makefile for radios with Silicon Labs Si470x FM Radio Receivers # -radio-si470x-objs := radio-si470x-usb.o radio-si470x-common.o -radio-si470x-i2c-objs := radio-si470x-i2c.o radio-si470x-common.o +si470x-usb-objs := radio-si470x-usb.o radio-si470x-common.o +si470x-i2c-objs := radio-si470x-i2c.o radio-si470x-common.o -obj-$(CONFIG_USB_SI470X) += radio-si470x.o -obj-$(CONFIG_I2C_SI470X) += radio-si470x-i2c.o +obj-$(CONFIG_USB_SI470X) += si470x-usb.o +obj-$(CONFIG_I2C_SI470X) += si470x-i2c.o > > Thanks. > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
