Hello, Tobias On Mon, Apr 13, 2009 at 12:56 AM, Tobias Lorenz <tobias.lorenz@xxxxxxx> wrote: > Hi Joonyoung, > > Hi Alexey, > > I've split the driver into a couple of segments: > > - radio-si470x-common.c is for common functions > > - radio-si470x-usb.c are the usb support functions > > - radio-si470x-i2c.c is an untested prototyped file for your i2c support > functions > > - radio-si470x.h is a header file with everything required by the c-files > > I hope this is a basis we can start on with i2c support. What do you think? > > The URL is: > > http://linuxtv.org/hg/~tlorenz/v4l-dvb > > Bye, > > Toby Great! It's always interesting to see big changes. I understand i2c interface not so good and have only general questions. Many (most?) drivers in v4l tree were converted to use new v4l2- framework. For example, dsbr100 was converted to v4l2_device http://linuxtv.org/hg/v4l-dvb/rev/77f37ad5dd0c and em28xx was converted to v4l2_subdev http://linuxtv.org/hg/v4l-dvb/rev/00525b115901 As i remember, Hans Verkuil said that all v4l drivers should be converted to new framework. Is it time to switch to this new interface ? Probably, there are a lot of code examples in current tree that can help.. And second question. About lock/unlock_kernel in open functions. Please, take a look at http://www.spinics.net/lists/linux-media/msg04057.html Well, is it time to do something with this? Well, my questions about improving functionality, not about mistakes or bugs :) -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
