On Fri, 03 Apr 2009 20:29:08 +0200 Erik Andrén <erik.andren@xxxxxxxxx> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi Jean-Francois, > > Please pull http://linuxtv.org/hg/~eandren/v4l-dvb/ > for more m5602-gspca changeset that are 2.6.30 material. > > Thanks, > Erik Hi Erik, Please always check your patch with "make checkpatch" or by running checkpatch.pl directly. There are some CodingStyle issues. Please send a patch fixing at least the ones bellow: gspca - m5602-s5k4aa: Add start function and VGA resolution init. ERROR: that open brace { should be on the previous line #27: FILE: linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c:134: + switch (cam->cam_mode[sd->gspca_dev.curr_mode].width) + { total: 1 errors, 0 warnings, 126 lines checked gspca - m5602-mt9m111: Separate mode vectors per sensor. ERROR: do not use C99 // comments #136: FILE: linux/drivers/media/video/gspca/m5602/m5602_ov9650.c:159: +// sd->gspca_dev.cam.cam_mode = ov9650.modes; ERROR: do not use C99 // comments #137: FILE: linux/drivers/media/video/gspca/m5602/m5602_ov9650.c:160: +// sd->gspca_dev.cam.nmodes = ov9650.nmodes; total: 2 errors, 0 warnings, 336 lines checked WARNING: braces {} are not necessary for single statement blocks #125: FILE: linux/drivers/media/video/gspca/m5602/m5602_ov9650.c:349: + for (i = 0; i < 2 && !err; i++) { + err = m5602_write_bridge(sd, M5602_XB_VSYNC_PARA, 0); + } Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
