On Sun, 5 Apr 2009 07:09:18 -0300 Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote: > On Fri, 3 Apr 2009 21:34:59 +0200 (CEST) > Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: > > > Hi Mauro, > > > > > 04/04: Add camera (CSI) driver for MX1 > > http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=f115ddf29d64 > > There are two checkpatch.pl warnings on the last one. Please add later a patch to fix. > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > #128: FILE: linux/arch/arm/mach-mx1/ksym_mx1.c:17: > +EXPORT_SYMBOL(mx1_camera_sof_fiq_start); > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > #129: FILE: linux/arch/arm/mach-mx1/ksym_mx1.c:18: > +EXPORT_SYMBOL(mx1_camera_sof_fiq_end); Hmm... I also suspect that you can do some cleanups at the includes. For example, You don't need this one: +#include <linux/moduleparam.h> since it is already included by module.h. > > Cheers, > Mauro > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
