On Sat, 2009-04-04 at 16:23 +0200, Jean Delvare wrote: > Hi Andy, > > Thanks for the fast review. > > On Sat, 04 Apr 2009 08:46:00 -0400, Andy Walls wrote: > > Correct, actually my initial attempt looked like this. But then patch > 3/6 adds code, which makes "your" solution 2 lines bigger, while "my" > solution stays as is, so the difference between both becomes very thin. > > Some developers (including me) prefer to have a single error path, > others hate gotos more than (potential) code duplication. I didn't know > what you'd prefer as the driver maintainer. If you want me to use the > variant without gotos, I can do that, no problem. Meh, whichever way you like is fine for now. If I really decide to care about it, I'll muck with it when I get the hardware I2C masters working. I'll have to touch that section of code at that time anyway. Acked-by: Andy Walls <awalls@xxxxxxxxx> Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
