On Wednesday 01 April 2009 11:43:28 Eduardo Valentin wrote: > Hello Mauro and v4l guys, > > This series contains a v4l2 radio driver which > adds support for Silabs si4713 devices. That is > a FM transmitter device. > > As you should know, v4l2 does not contain representation > of FM Transmitters (at least that I know). So this driver > was written highly based on FM receivers API, which can > cover most of basic functionality. However, as expected, > there are some properties which were not covered. > For those properties, sysfs nodes were added in order > to get user interactions. > > Comments are wellcome. Can you explain in reasonable detail the extra properties needed for a device like this? You will need to document that anyway :-) Rather than implementing a private API it would be much more interesting to turn this into a public V4L2 API that everyone can use. How does one pass the audio and rds data to the driver? Note that for 2.6.31 we will finalize the V4L2 RDS decoder API (I recently posted an RFC for that, but I haven't had the time to implement the few changes needed). It would be nice if rds modulator support would be modeled after this demodulator API if possible. Does region information really belong in the driver? Perhaps this should be in a user-space library? (just a suggestion, I'm not sure at this stage). A general comment: the si4713 driver should be a stand-alone i2c driver. That way it can be reused by other drivers/platforms that use this chip. The v4l2_subdev framework should be used for this. Always interesting to see new functionality arrive in V4L2 :-) Regards, Hans > > Eduardo Valentin (3): > FMTx: si4713: Add files to handle si4713 device > FMTx: si4713: Add files to add radio interface for si4713 > FMTx: si4713: Add Kconfig and Makefile entries > > drivers/media/radio/Kconfig | 12 + > drivers/media/radio/Makefile | 2 + > drivers/media/radio/radio-si4713.c | 834 ++++++++++++++ > drivers/media/radio/radio-si4713.h | 32 + > drivers/media/radio/si4713.c | 2238 > ++++++++++++++++++++++++++++++++++++ drivers/media/radio/si4713.h | > 294 +++++ > 6 files changed, 3412 insertions(+), 0 deletions(-) > create mode 100644 drivers/media/radio/radio-si4713.c > create mode 100644 drivers/media/radio/radio-si4713.h > create mode 100644 drivers/media/radio/si4713.c > create mode 100644 drivers/media/radio/si4713.h > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
