Re: soc_camera_open crash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 31 Mar 2009, morimoto.kuninori@xxxxxxxxxxx wrote:

> 
> Hi Guennadi
> 
> I tyied to use latest Linux 2.6.29 from Paul's git
>  git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6.git
> 
> soc_camera doesn't work on it.
> And I found the reason.
> 
> -------------
> static int soc_camera_open(struct file *file)
> {
>    ...
> 	if (icd->use_count == 1) {
> 		/* Restore parameters before the last close() per V4L2 API */
> 		struct v4l2_format f = {
> 			.type = V4L2_BUF_TYPE_VIDEO_CAPTURE,
> 			.fmt.pix = {
> 				.width		= icd->width,
> 				.height		= icd->height,
> 				.field		= icd->field,
> =>				.pixelformat	= icd->current_fmt->fourcc,
> =>				.colorspace	= icd->current_fmt->colorspace,
> 			},
> 		};
> ...
> 		ret = soc_camera_set_fmt(icf, &f);
> ------------- 
> 
> now, icd->current_fmt seems NULL.
> So, I can not call soc_camera_set_fmt.

Strange, it should not be NULL, it should be initialised in 
soc_camera_init_user_formats() during probing. Could you verify whether it 
gets initialised there?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux