On Monday 30 March 2009 13:31:55 Mauro Carvalho Chehab wrote: > On Sun, 29 Mar 2009 15:36:46 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > > Hi Mauro, > > > > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-cx88 for the > > following: > > > > - cx88: convert to v4l2_subdev. > > I only noticed this, when I tried to compile with an old kernel: > > diff --git a/linux/drivers/media/video/cx88/cx88-video.c b/linux/drivers/media/ > video/cx88/cx88-video.c > <snip/> > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 22) > + static struct i2c_board_info rtc_info = { > + I2C_BOARD_INFO("isl1208", 0x6f) > + }; > + > request_module("rtc-isl1208"); > + core->i2c_rtc = i2c_new_device(&core->i2c_adap, &rtc_info); > +#else > + request_module("rtc-isl1208"); > +#endif > + } > > Where is the isl1208 driver? I can't see it. It's an rtc (real-time clock) driver that's part of the drivers/rtc subdirectory in the kernel. Apparently this particular board needs to set up this rtc device by loading this driver for proper operation. > For what purpose we need this driver? The other Isil drivers are power control > drivers for DVB. If this is the case, we should move this code to cx88-dvb. It's perfectly OK where it is. But since that driver was also converted to the new style API we need to use i2c_new_device to load it since just calling request_module will no longer work for this driver. Hence this change in the code. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
