Hello, Jean-Francois What do you think about such small cleanup ? --- Patch reformats sd_mod_init in the way to make it return error code from usb_register instead of -1. Signed-off-by: Alexey Klimov <klimov.linux@xxxxxxxxx> -- diff -r 56cf0f1772f7 linux/drivers/media/video/gspca/mr97310a.c --- a/linux/drivers/media/video/gspca/mr97310a.c Mon Mar 23 19:18:34 2009 -0300 +++ b/linux/drivers/media/video/gspca/mr97310a.c Fri Mar 27 01:42:28 2009 +0300 @@ -347,8 +347,10 @@ /* -- module insert / remove -- */ static int __init sd_mod_init(void) { - if (usb_register(&sd_driver) < 0) - return -1; + int ret; + ret = usb_register(&sd_driver); + if (ret < 0) + return ret; PDEBUG(D_PROBE, "registered"); return 0; } -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html