On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: > > >> + /* common v4l buffer stuff -- must be first */ > > >> + struct videobuf_buffer vb; > > >> > > > > > > Here you have one space > > > > > > > > >> + > > >> + const struct soc_camera_data_format *fmt; > > >> > > > > > > Here you have 8 spaces > > > > > > > > >> + > > >> + int inwork; > > >> > > > > > > Here you have tabs. Please, unify. > > Please always check your patches with checkpatch.pl. This will point such issues. No, I did check the patch with checkpatch.pl and it didn't complain about this. It checks _indentation_ of lines, that _must_ be done with TABs, but it doesn't check what is used for alignment _inside_ lines, like xxx = 0; y = 1; zzzzz = 2; where first and third lines have spaces before "=", and the second one has a TAB. This is not checked by checkpatch.pl. Thanks Guennadi --- Guennadi Liakhovetski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
