Re: [PULL] http://linuxtv.org/hg/~jfrancois/v4l-dvb/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Mar 2009 11:19:42 +0100
Jean-Francois Moine <moinejf@xxxxxxx> wrote:

> Hi Mauro,
> 
> Please pull from http://linuxtv.org/hg/~jfrancois/v4l-dvb/
> for:
> 
> changeset:   11141:8f6800be5b0f
> gspca - vc032x: New sensor mi1320_soc and webcam 15b8:6001 added.
> 
> changeset:   11156:fb4ba7eaa8b0
> gspca - vc032x: Simplify the i2c write function.
> 
> changeset:   11157:01ea4082081f
> gspca - vc032x: Use YVYU format for sensor mi1320_soc.

There's a small typo on this patch:

+/*fixme: jeg does not work

s/jeg/jpeg/

Btw, It would be better if you use:

#if 0
	/* the jpeg code that doesn't work yet */
	...
#endif

The advantages are that the #if 0 would be stripped from kernel. Also, this is
the common way for adding code that aren't working yet.

If you want to keep the comments upstream, you can use, instead:

#if 0 /* keep */
	/* the jpeg code that doesn't work yet */
	...
#endif

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux