On Tue, 24 Mar 2009 23:07:02 -0500 (CDT) Mike Isely <isely@xxxxxxxxx> wrote: > > Mauro: > > Please pull from http://linuxtv.org/hg/~mcisely/pvrusb2 for a large > collection of pvrusb2 changesets (see below). Applied, thanks! > Way back around > November 2005, I had written a large chunk of code in the driver to > provide uniform control of the associated i2c modules. With the > advent of the v4l2-subdev framework within V4L, that old i2c layer in > the pvrusb2 driver has become obsolete. The vast majority of these > changes transform the pvrusb2 driver such that it now uses the > v4l2-subdev framework, replacing the old i2c module control layer. In > the end, the pvrusb2 driver is somewhat simpler now. Great! > I recommend that this whole things find its way into the 2.6.30 kernel > merge window. Ok. > > Note: This will not be checkpatch.pl "clean". It was not that bad. For a big series like this, there aren't many violations (see bellow). > Though I have taken great care to abide by the questionable space-after-comma silliness > (and boy did that suck - it's not AT ALL easy to change a 21 year > habit), I know. I have the same habit of not using spaces after comma. I always need to review this. > other warnings will still be present. The high-runner will be > things related to single-line or compound if-statements. We've had > that discussion before and I anticipate not to have to repeat it > again. I don't remember any other warnings of any real consequence. Except for the if statements, the remaining ones seem to be due to the usage of more than one instruction per line. > Oh one thing, part of this series involved an early changeset that > moves a large chunk of old code to a new file. That changeset will be > rife with checkpatch.pl complaints, but it's code that is otherwise > unchanged and I'm not about to sanitize it all purely for the sake of > that script. (Besides, most if not all of that old code goes away in > a later changeset anyway.) I suspect that all code were removed, at least by looking at the checkpatch when you apply everything just like one big patch. Cheers, Mauro --- FYI, this is the checkpatch.pl for the entire series. /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-audio.c: In ' if ((sid < ARRAY_SIZE(routing_schemes)) &&': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-audio.c:68: ERROR: do not use assignment in if condition /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c: In ' if ((sid < ARRAY_SIZE(routing_schemes)) &&': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c:117: ERROR: do not use assignment in if condition /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!src) return 0;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:1989: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!i2ccnt && ((p = (mid < ARRAY_SIZE(module_i2c_addresses)) ?': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2026: ERROR: do not use assignment in if condition /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' default: break;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2117: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' }': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2132: warning: braces {} are not necessary for single statement blocks /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (pvr2_hdw_load_subdev(hdw, &ct->lst[idx]) < 0) okFl = 0;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2138: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!okFl) pvr2_hdw_render_useless(hdw);': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2140: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!pvr2_hdw_dev_ok(hdw)) return;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2203: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (hdw->tuner_signal_stale) pvr2_hdw_status_poll(hdw);': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:2996: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' } else {': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:3006: warning: braces {} are not necessary for any arm of this statement /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (id >= ARRAY_SIZE(pvr2_module_update_functions)) continue;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:3052: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!fp) continue;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:3054: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' }': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:3058: warning: braces {} are not necessary for single statement blocks /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!cptr->info->clear_dirty) continue;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:3254: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (id < ARRAY_SIZE(module_names)) p = module_names[id];': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:4932: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' }': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:4959: warning: braces {} are not necessary for single statement blocks /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' }': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:5021: warning: braces {} are not necessary for single statement blocks /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c: In ' if (!setFl) *val_ptr = req.val;': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c:5336: ERROR: trailing statements should be on next line /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-video-v4l.c: In ' if ((sid < ARRAY_SIZE(routing_schemes)) &&': /home/v4l/master/linux/drivers/media/video/pvrusb2/pvrusb2-video-v4l.c:84: ERROR: do not use assignment in if condition Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
