Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes: > pxa_dma_update_sg_tail() is called only once, runs exactly the same loop as the > caller and has to recalculate the last element in an sg-list, that the caller > has already calculated. Eliminate redundancy by merging the two loops and > re-using the calculated pointer. This also saves a bit of performance which is > always good during video-capture. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > --- > > On Mon, 16 Mar 2009, Robert Jarzmik wrote: > >> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes: >> >> > pxa_dma_update_sg_tail is called only here, why not inline it and also put >> > inside one loop? >> As for the inline, I'm pretty sure you know it is automatically done by gcc. >> >> As for moving it inside the loop, that would certainly improve performance. Yet >> I find it more readable/maintainable that way, and will leave it. But I won't be >> bothered at all if you retransform it back to your view, that's up to you. > > Robert, this is what I'm going to apply on top of your patch-series. > Please, object:-) Here you are : :) Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
