Dear Guennadi
Thank you for checking patch
> Whatever this "edge" does, isn't it so, that "threshold," "upper," and
> "lower" parameters configure it and "strength" actually enforces the
> changes? Say, if strength == 0, edge control is off, and as soon as you
> switch it to != 0, it is on with all the configured parameters? If my
> guess is right, wouldn't it make sense to first configure parameters and
> then set strength? If you agree, I'll just swap them when committing, so,
> you don't have to resend. Just please either confirm that you agree, or
> explain why I am wrong.
I don't know detail of these register's order.
Because my datasheet doesn't have detail explain.
For example, does "strength" actually enforce
all of configured parameters change ?
So, I tried to test whether these register setting
order were important.
It seems to be independent apparently respectively.
For example, I can change only "upper" register and
the setting was effective.
So, I will ask to maker about these register's behavior.
Because it seems to relate to other register.
So, please ignore this patch until I get answer. sorry.
> +#define OV772X_EDGECTRL(s, t, u, l) \
> +{ \
> + .strength = (s & 0x1F), \
> + .threshold = (t & 0x0F), \
> + .upper = (u & 0xFF), \
> + .lower = (l & 0xFF), \
> +}
I will fix this in next =)
Best regards
--
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
