On Tue, Mar 24, 2009 at 4:24 PM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > >> -static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) >> +static long dabusb_ioctl (struct file *file, unsigned int cmd, unsigned long arg) >> { >> + lock_kernel(); >> pdabusb_t s = (pdabusb_t) file->private_data; > > After the variables or you'll get lots of warnings from gcc > > Unfortunately I am not familiar with this driver and as such i was not sure if the variable required the lock to be accessed or not so as to play it safe i put it before the variable. But i can resubmit this patch if there are no problems. -- -Stoyan -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html