Re: [PATCH] ov772x: add edge contrl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Guennadi

> Is edge_strength == 0 a useful edge configuration? Cannot you use it as a 
> test whether to set all edge parameters or not? If you cannot, well, just 
> do the same as what you have done with 32-bits - use one bit in strength 
> as "edge enable" - just exactly in the same way as in your patch. Like
> 
> 	if (edge_strength & EDGE_ENABLE) {
> 		set_strength;
> 		set_threshold;
> 		set_low;
> 		set_high;
> 	}

Hmm..
edge_threshold has 4 un-used bit.
we can use it for judge.

And sorry, I don't like this style
	unsigned char	edge_strength;
	unsigned char	edge_threshold;
	unsigned char	edge_low;
	unsigned char	edge_high;

I will create new struct ov772x_edge for it.

Best regards
--
Kuninori Morimoto
 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux